Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): include details in error responses #554

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

Josh-Matsuoka
Copy link
Contributor

@Josh-Matsuoka Josh-Matsuoka commented Jul 9, 2024

Fixes #394
See also cryostatio/cryostat-web#1295

This PR updates the cryostat compose to set the appropriate flags for smallrye graphQL to pass on errors in a format that the web UI can work with. These flags ensure that the underlying exception and message are passed on in the response rather than a generic Server Error and DataFetchingException.

compose/cryostat.yml Outdated Show resolved Hide resolved
@andrewazores andrewazores changed the title Graphql fix fix(graphql): include details in error responses Jul 10, 2024
@andrewazores
Copy link
Member

/build_test

Copy link

github-actions bot commented Aug 6, 2024

Workflow started at 8/6/2024, 11:33:57 AM. View Actions Run.

Copy link

github-actions bot commented Aug 6, 2024

No OpenAPI schema changes detected.

Copy link

github-actions bot commented Aug 6, 2024

No GraphQL schema changes detected.

Copy link

github-actions bot commented Aug 6, 2024

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat/actions/runs/10269541606

@andrewazores
Copy link
Member

^ working on that.

@andrewazores
Copy link
Member

/build_test

Copy link

github-actions bot commented Aug 6, 2024

Workflow started at 8/6/2024, 12:11:04 PM. View Actions Run.

Copy link

github-actions bot commented Aug 6, 2024

No GraphQL schema changes detected.

Copy link

github-actions bot commented Aug 6, 2024

No OpenAPI schema changes detected.

Copy link

github-actions bot commented Aug 6, 2024

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/10270109742

@andrewazores
Copy link
Member

/build_test

Copy link

github-actions bot commented Aug 7, 2024

Workflow started at 8/7/2024, 5:23:00 PM. View Actions Run.

Copy link

github-actions bot commented Aug 7, 2024

No GraphQL schema changes detected.

Copy link

github-actions bot commented Aug 7, 2024

No OpenAPI schema changes detected.

Copy link

github-actions bot commented Aug 7, 2024

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/10291947147

@andrewazores andrewazores merged commit 07b936f into cryostatio:main Aug 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] GraphQL requests do not properly support custom auth/TLS error status codes
2 participants